Pearl1594 opened a new pull request, #14062: URL: https://github.com/apache/cloudstack/pull/14062
### Description This PR fixes: https://github.com/apache/cloudstack/issues/14056 <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? Network Offering clone: 1. Clone an existing isolated network offering, change say, userdata provider from VirtualRouter to ConfigDrive and submit. listNetworkOfferings on the result and confirm the new provider actually persisted. 2. Clone the same offering, leave services untouched, submit - confirm it clones same as source 2. Clone an NSX-backed offering - confirm services/providers stay greyed out and fixed, unaffected by any of the above. VPC Offering clone: 1. Clone a VPC offering, edit Name/Display Text/Service Offering/Redundant Router, then change Network Mode (NATTED <->ROUTED) before submitting - confirm those edits survive 2. While in NATTED, check/uncheck a couple of services and change their providers, then flip to ROUTED and back to NATTED - confirm the edits to available services are preserved, and confirm mode-excluded services (SourceNat/StaticNat/Lb/PortForwarding/Vpn) are unchecked in ROUTED and require an explicit re-check after returning to NATTED 3. Submit after a mode change (as in test 2) and confirm the API payload doesn't include stale entries for services no longer shown in the form . <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
