shwstppr commented on code in PR #13830:
URL: https://github.com/apache/cloudstack/pull/13830#discussion_r3957628816
##########
plugins/storage/sharedfs/storagevm/src/main/java/org/apache/cloudstack/storage/sharedfs/lifecycle/StorageVmSharedFSLifeCycle.java:
##########
@@ -180,7 +180,10 @@ private UserVm deploySharedFSVM(Long zoneId, Account
owner, List<Long> networkId
for (final Iterator<Hypervisor.HypervisorType> iter =
hypervisors.iterator(); iter.hasNext();) {
final Hypervisor.HypervisorType hypervisor = iter.next();
VMTemplateVO template =
templateDao.findSystemVMReadyTemplate(zoneId, hypervisor,
preferredArchitecture);
- if (template == null && !iter.hasNext()) {
+ if (template == null) {
+ if (iter.hasNext()) {
+ continue;
Review Comment:
Maybe a log here would be helpful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]