Hanarion commented on PR #12144:
URL: https://github.com/apache/cloudstack/pull/12144#issuecomment-5586882602
@DaanHoogland applied the stubs and made the category uuid not null.
For `SERVICE_OFFERING_CATEGORY_NAME`, copilot is right that it's missing but
the fix is on the description side. The name is never sent as a parameter, it's
only returned in the response as category (`@SerializedName("category")` in
`ServiceOfferingResponse`), so a constant for it would be dead code. I removed
it earlier for that reason and the description was never updated. Fixed the
description instead.
For the FK i'd rather keep it as is, `IDEMPOTENT_ADD_FOREIGN_KEY` hardcodes
`ON DELETE CASCADE` and we need `RESTRICT`, otherwise deleting a category
deletes all its offerings. It's already idempotent with the
`IDEMPOTENT_DROP_FOREIGN_KEY` above.
For the schema file, there is no 23 -> 24 file yet from what i see, the
chain still ends at Upgrade42210to42300. Do you want me to create it here or
does it come with a version bump PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
