nagaboinaramgopal opened a new pull request, #14105: URL: https://github.com/apache/cloudstack/pull/14105
### Description When primary storage is taken out of maintenance, the KVM agent can find the libvirt storage pool still defined and active and reuse it, even though the NFS share was unmounted while the pool was in maintenance. The pool then stays logically Up while its mount point is gone on the host, and operations fail with "libvirt failed to mount storage pool". For a NetworkFilesystem pool that libvirt reports as active, this also checks that the target path is actually mounted. If it is not, the pool is undefined so the existing create path recreates and remounts it. A properly mounted pool is still reused as before. Fixes: #12690 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [x] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): N/A ### How Has This Been Tested? Added a unit test where the pool is active but the mountpoint check fails: it verifies the pool is undefined and destroyed so it can be recreated and remounted. Before this change that test fails, because the pool is reused as is. A second test confirms a pool that is actually mounted, with matching mount options, is still reused and not touched. #### How did you try to break this feature and the system with this change? The change only adds a remount for the active but unmounted case. A properly mounted pool with matching options is still reused untouched, which the mount-options test covers, so normal operation is unaffected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
