winterhazel commented on code in PR #12650:
URL: https://github.com/apache/cloudstack/pull/12650#discussion_r3974735829
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -2479,4 +2479,9 @@ public VirtualMachineTemplate
linkUserDataToTemplate(LinkUserDataToTemplateCmd c
return _tmpltDao.findById(template.getId());
}
+
+ private void throwExceptionForImageStoreObtentionFailure(Long zoneId,
String operation) {
+ logger.error("Cannot find an image store for zone [{}] while trying to
{}.", zoneId, operation);
+ throw new CloudRuntimeException(String.format("Failed to %s. Please
contact the cloud administrator.", operation));
Review Comment:
@erikbocks I think we can throw a more informative `CloudRuntimeException`
here instead, stating which zone it is (either the name or the UUID). These are
automatically converted to a more generic message for non-root admin accounts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
