weizhouapache commented on PR #14094: URL: https://github.com/apache/cloudstack/pull/14094#issuecomment-5615273726
> > This condition check was added in the KBOSS PR (#12758). > > I’m not sure why it was added to the providers (excluding KBOSS). I assume this is a typo and that it should apply to KBOSS only. > > Please correct me if I’m wrong. @JoaoJandre @winterhazel > > This was my error when cherry-picking the changes to main. The original branch I was working on had #7221 applied, which introduced this check for all providers. I thought it was there for a reason for other providers, so I just added an exception for KBOSS. > > You can just remove the condition as a whole. It does not make sense for KBOSS. I don't think the condition makes sense for any provider actually. @JoaoJandre thanks for the information. I have updated the PR to remove the check as you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
