sureshanaparti commented on code in PR #13897:
URL: https://github.com/apache/cloudstack/pull/13897#discussion_r3977368256
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiAdmStorageAdaptor.java:
##########
@@ -90,12 +96,16 @@ public KVMPhysicalDisk createPhysicalDisk(String
volumeUuid, KVMStoragePool pool
@Override
public boolean connectPhysicalDisk(String volumeUuid, KVMStoragePool pool,
Map<String, String> details, boolean isVMMigrate) {
+ final String host = pool.getSourceHost();
+ final int port = pool.getSourcePort();
+ final String iqn = getIqn(volumeUuid);
Review Comment:
can this be null (any case where no volume associated with the given uuid)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
