dheeraj12347 commented on PR #13895: URL: https://github.com/apache/cloudstack/pull/13895#issuecomment-5652270018
Hi @Damans227 , @Pearl1594 Thanks for the review and for testing this. I’ve addressed the issues raised in the review: - Added `CPUArch.toString()` to return the `type` value, so API discovery now exposes the same values that the API accepts. I also updated the affected `ListTemplatesCmd` and `ListIsosCmd` descriptions to include `i686`. - Added `TemplateApiType` validation in `TemplateManagerImpl` before mapping to `Storage.TemplateType`, so values such as `PERHOST`, `DATADISK`, and `ISODISK` that are not advertised by the API are rejected. - Updated `check_allowed_values.py` so that when `allowedValueType` can be resolved, it compares the enum-derived values against the valid values listed in the parameter description instead of skipping the check. Added regression coverage for the `CPUArch` mismatch case. - Left the unrelated `StringUtils.join()` issue out of this PR as it is outside the scope of this change. Validation completed: - `python3 -m unittest scripts/test_check_allowed_values.py` — 14/14 passed - `mvn -pl server -am -Dtest=TemplateManagerImplTest -DfailIfNoTests=false test` — 35/35 passed - `git diff --check` — clean - Checkstyle — 0 violations The changes have been pushed in commit `fba666fab2`. Please take another look when the CI checks complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
