github-actions[bot] commented on issue #14168: URL: https://github.com/apache/cloudstack/issues/14168#issuecomment-5681227782
## ๐ฏ Triage report This request asks that VPC tiers be allowed to set custom DNS (currently refused by an unconditional check in `NetworkServiceImpl.checkNetworkDns`) and that `updateVPC` gain `dns1`/`dns2`/`ip6dns1`/`ip6dns2` parameters. The author provides detailed code references and a behavior matrix across multiple versions (4.18โ4.23), and raises an open question for maintainers about whether the current restriction is intentional for non-VR-backed VPCs (e.g., NSX/Netris). ### ๐ Assessment | Dimension | Value | Reasoning | |---|---|---| | **Type** | `type:enhancement` | Requests new/extended API behavior (DNS on VPC tiers, updatable VPC DNS) rather than reporting broken existing behavior. | | **Component** | `component:vpc`, `component:networking` | Directly concerns VPC tier and VPC-level DNS handling. | | **Severity** | n/a | Not a bug; feature/behavior gap. | | **Labels** | type:enhancement, component:vpc, component:networking | See above. | | **Coding agent** | Needs more info | The tier-DNS half looks like a scoped code change (removing/narrowing a guard clause), but the VPC-level "inherit vs explicit" semantics for `updateVPC` require a design decision (e.g., NULL-as-inherit) and confirmation of behavior for non-VR-backed VPCs (NSX/Netris) before implementation can safely proceed. | ### ๐ Similar issues No similar or duplicate open issues found via search. Related closed/merged work referenced by the author: #6425, #8598, #8621. <details><summary>๐ก Notes and suggestions</summary> - Maintainers should clarify whether the `vpcId != null` guard in `checkNetworkDns` was an intentional restriction for VPC implementations without VR-managed DNS (NSX/Netris), as the author suggests narrowing the check to those providers only. - The VPC-level DNS "inherit" semantics (tier follows VPC unless explicitly set) is the main open design question โ worth resolving on the mailing list or in a comment before a PR is opened. - If pursued, the tier-DNS change and the `updateVPC` parameter addition could be split into two smaller, separately reviewable changes. </details> > Generated by [Daily Issue Triage](https://github.com/apache/cloudstack/actions/runs/34975614423) ยท sonnet50 86.7K ยท [โท](https://github.com/search?q=repo%3Aapache%2Fcloudstack+%22gh-aw-workflow-call-id%3A+apache%2Fcloudstack%2Fdaily-issue-triage%22&type=issues) > <details> <summary>Add this agentic workflows to your repo</summary> To install this agentic workflow, run ``` gh aw add githubnext/agentics/workflows/daily-issue-triage.md@d7c1dc4b72b00607a67caaffdcc216cb64379cf9 ``` </details> <!-- gh-aw-agentic-workflow: Daily Issue Triage, engine: copilot, version: 1.0.52, model: claude-sonnet-5, id: 34975614423, workflow_id: daily-issue-triage, run: https://github.com/apache/cloudstack/actions/runs/34975614423 --> <!-- gh-aw-workflow-call-id: apache/cloudstack/daily-issue-triage --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
