kiranchavala commented on code in PR #13737:
URL: https://github.com/apache/cloudstack/pull/13737#discussion_r4022530235
##########
systemvm/debian/root/health_checks/iptables_check.py:
##########
@@ -41,13 +41,14 @@ def main():
fetchIpTableEntriesCmd = "iptables-save | grep " + destIp
pout = Popen(fetchIpTableEntriesCmd, shell=True, stdout=PIPE)
- if pout.wait() != 0:
+ stdout, _ = pout.communicate()
+ if pout.returncode != 0:
failedCheck = True
Review Comment:
@richevanscybermyte can you check if the co-pilot comment is valid
@weizhouapache tested the fix , we can merge the pr if there are no
objections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
