sureshanaparti commented on code in PR #13877:
URL: https://github.com/apache/cloudstack/pull/13877#discussion_r4033673377
##########
plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java:
##########
@@ -327,6 +721,11 @@ private Pair<Boolean, String>
restoreVMBackup(VirtualMachine vm, Backup backup)
} catch (OperationTimedoutException e) {
throw new CloudRuntimeException("Operation to restore backup timed
out, please try again");
}
+ // After a restore the QEMU dirty-bitmap chain is gone — clear
active_checkpoint_id so
+ // the next backup is taken as a fresh full and starts a new chain.
See decideChain.
+ if (answer != null && answer.getResult()) {
+ clearVmActiveCheckpoint(vm.getId());
+ }
return new Pair<>(answer.getResult(), answer.getDetails());
Review Comment:
any possibility for `answer` to be null here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
