weizhouapache commented on code in PR #14203:
URL: https://github.com/apache/cloudstack/pull/14203#discussion_r4047959403
##########
plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java:
##########
@@ -383,6 +383,24 @@ protected boolean
allVolumesOnCheckpointCapableStorage(VirtualMachine vm) {
return true;
}
+ /**
+ * True when any of the VM's volumes sits on a StorPool pool. Used to
decide whether volume
+ * pool/path info must be sent to the agent even though the VM currently
looks Running — see
+ * the caller in {@link #takeBackup}.
+ */
+ private boolean hasStorPoolVolume(List<VolumeVO> volumes) {
Review Comment:
I would suggest to pass pooltype as a parameter of the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
