harikrishna-patnala commented on code in PR #12336:
URL: https://github.com/apache/cloudstack/pull/12336#discussion_r4118901026
##########
api/src/main/java/org/apache/cloudstack/api/response/ExceptionResponse.java:
##########
@@ -44,6 +44,14 @@ public class ExceptionResponse extends BaseResponse {
@Param(description = "The text associated with this error")
private String errorText = "Command failed due to Internal Server Error";
+ @SerializedName("errortextkey")
+ @Param(description = "the key for the text associated with this error",
since = "4.24.0")
Review Comment:
change the version to 4.22.2 !!
##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##########
@@ -656,9 +655,9 @@ public void expunge(final String vmUuid) throws
ResourceUnavailableException {
try {
advanceExpunge(vmUuid);
} catch (final OperationTimedoutException e) {
- throw new CloudRuntimeException("Operation timed out", e);
+ throw
Exceptions.cloudRuntimeException("vm.expunge.operation.timeout", Map.of(), e);
Review Comment:
any specific reason for not adding the resource details here ? I see we have
added it in few other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
