Copilot commented on code in PR #13325: URL: https://github.com/apache/cloudstack/pull/13325#discussion_r4129964702
########## engine/schema/src/main/resources/META-INF/db/schema-42300to2400.sql: ########## @@ -18,3 +18,7 @@ --; -- Schema upgrade from 4.23.0.0 to 24.0.0 --; + +ALTER TABLE `cloud`.`nics` ADD COLUMN `network_rate` int DEFAULT NULL COMMENT 'effective network rate in Mb/s for this NIC, -1 means unlimited'; + +ALTER TABLE `cloud`.`vpc_offerings` ADD COLUMN `public_nw_rate` int unsigned DEFAULT NULL COMMENT 'public gateway (internet-facing) network rate throttle mbits/s'; Review Comment: The upgrade script adds the new base columns but never recreates `user_vm_view`, `domain_router_view`, or `vpc_offering_view`. The changed view definition files are used for fresh schema creation, but an existing 4.23 database keeps the old view definitions; once the new join VOs query `nic_network_rate` or `public_nw_rate`, upgrades will fail with an unknown-column error. Add the corresponding DROP/CREATE (or CREATE OR REPLACE) view statements to this upgrade path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
