Damans227 commented on code in PR #14249:
URL: https://github.com/apache/cloudstack/pull/14249#discussion_r4175885514
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -1235,9 +1235,9 @@ private void setVpcIdInResponse(Long vpcId,
Consumer<String> vpcUuidSetter, Cons
}
}
- private void showVmInfoForSharedNetworks(boolean forVirtualNetworks,
IpAddress ipAddr, IPAddressResponse ipResponse) {
+ protected void showVmInfoForSharedNetworks(boolean forVirtualNetworks,
IpAddress ipAddr, IPAddressResponse ipResponse) {
if (!forVirtualNetworks) {
- NicVO nic =
ApiDBUtils.findByIp4AddressAndNetworkId(ipAddr.getAddress().toString(),
ipAddr.getNetworkId());
+ NicVO nic =
ApiDBUtils.findNonPlaceHolderByIp4AddressAndNetworkId(ipAddr.getAddress().toString(),
ipAddr.getNetworkId());
Review Comment:
what happens once the router is destroyed and only the placeholder is left?
looks like the ip would stop showing as a system ip and the ui would offer
release on it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
