Damans227 commented on code in PR #14000:
URL: https://github.com/apache/cloudstack/pull/14000#discussion_r4184044883
##########
engine/orchestration/src/main/java/com/cloud/cluster/agentlb/ClusterBasedAgentLoadBalancerPlanner.java:
##########
@@ -88,37 +88,54 @@ public List<HostVO>
getHostsToRebalance(ManagementServerHostVO ms, int avLoad) {
hostToClusterMap = sortByClusterSize(hostToClusterMap);
Review Comment:
does the cluster sort here actually reorder anything? its compare never says
one cluster comes first, so the order looks random and which cluster gets split
depends on that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
