PrashantBhanage commented on PR #13490: URL: https://github.com/apache/cloudstack/pull/13490#issuecomment-6015970820
@DaanHoogland @Damans227 I went through the Copilot findings against the current main branch after syncing the PR and restored the behavior that had been missing from the refactor, including: - key-pair response fields - domain resource tags - port-forwarding network name - system VM storage IP - keepmacaddressonpublicnic handling - VPC conserve mode - VPN gateway parameter indicators - secondary-IP descriptions - NIC enabled state - usage-response dispatcher coverage The refactor itself remains focused on modularizing ApiResponseHelper#createUsageResponse(Usage), without intentionally changing the existing behavior. I also addressed the two maintainer concerns that were still actionable. The remaining maintainer point was style-only, as noted. Validation completed: - ApiResponseHelperTest: 5/5 passing - createUsageResponse dispatcher test: 1/1 passing - clean working tree - latest fixes pushed in commit 0e07fe6 Could you please take another look at the updated PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
