jmsperu commented on PR #12847: URL: https://github.com/apache/cloudstack/pull/12847#issuecomment-6018763243
Pushed 3340496b0a for @Damans227's two questions (hostDao injection fixed with a regression test; the per-host cap is per management server, now documented with the sizing rule). NASBackupProviderTest 6/6 locally, checkstyle clean. On the red Simulator CI shard from the previous run: the failure is `test_network_permissions.test_03_network_operations_on_created_vm_of_otheruser`, where `updateVmNicIp` returned "Network is not in the right state to update vm nic ip", followed by a cleanup error in `test_06`. The simulator has no NAS backup provider and this PR only touches `TakeBackupCommand` and `NASBackupProvider`. The same test also shows up in the failure list of unrelated PRs (for example the Trillian result on #13592), so I think it is a flake. The new push will run it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
