Damans227 commented on code in PR #14282:
URL: https://github.com/apache/cloudstack/pull/14282#discussion_r4199309338
##########
server/src/main/java/com/cloud/network/NetworkModelImpl.java:
##########
@@ -2743,7 +2743,8 @@ public ConfigKey<?>[] getConfigKeys() {
@Override
public String getValidNetworkCidr(Network guestNetwork) {
String networkCidr = guestNetwork.getNetworkCidr();
- return networkCidr == null ? guestNetwork.getCidr() : networkCidr;
+ String cidr = networkCidr == null ? guestNetwork.getCidr() :
networkCidr;
+ return
com.cloud.utils.StringUtils.getFirstValueFromCommaSeparatedString(cidr);
Review Comment:
will vms that get an ip from the second range still get dhcp from the
router? looks like the router is only told about the first range now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
