Damans227 commented on code in PR #14114:
URL: https://github.com/apache/cloudstack/pull/14114#discussion_r4205875985


##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java:
##########
@@ -199,8 +197,8 @@ public VirtualMachineEntity createVirtualMachine(String id, 
String owner, String
             Map<String, String> userVmDetails = 
_userVmDetailsDao.listDetailsKeyPairs(vm.getId());
 
             if (userVmDetails != null) {
-                String minIops = userVmDetails.get(MIN_IOPS);
-                String maxIops = userVmDetails.get(MAX_IOPS);
+                String minIops = userVmDetails.get(VmDetailConstants.MIN_IOPS);

Review Comment:
   should the min and max check on deploy use these new names too? it still 
looks up the old ones, so a min above max now reaches the volume without an 
error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to