Damans227 commented on code in PR #14359:
URL: https://github.com/apache/cloudstack/pull/14359#discussion_r4218650433
##########
server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java:
##########
@@ -619,7 +620,8 @@ protected void validateProtocol(NetworkACLItemVO
networkACLItemVO) {
throw new InvalidParameterValueException("Invalid protocol
number: " + protoNumber);
}
} else {
- if
(!supportedProtocolsForAclRules.contains(protocol.toLowerCase())) {
+ // one of the names, not just part of the string: "cp" or "dp,ic"
must not pass
+ if
(!Arrays.asList(supportedProtocolsForAclRules.split(",")).contains(protocol.toLowerCase(Locale.ROOT)))
{
Review Comment:
should the firewall and routed network rules get the same fix? they use the
same part-of-the-string check, so "cp" still passes there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
