bhouse-nexthop commented on code in PR #14360:
URL: https://github.com/apache/cloudstack/pull/14360#discussion_r4219069096
##########
systemvm/debian/opt/cloud/bin/configure.py:
##########
@@ -81,6 +81,17 @@ def appendStringIfNotEmpty(s1, s2):
return s1
+# nft names of the IPv6 extension headers, which can also be given as an ACL
protocol number
+IP6_EXTHDR_NAMES = {0: "hbh", 43: "rt", 44: "frag", 60: "dst", 135: "mh"}
Review Comment:
Checked this one: when nft works out `meta l4proto` for IPv6 it stops at AH
rather than skipping it, so for an AH packet l4proto is 51. A `meta l4proto 51`
rule loaded through `apply_ip6_rules()` matched AH packets in nft, both with AH
directly after the IPv6 header and after Hop-by-Hop and Destination Options
headers, and left non-AH traffic alone. That's why 51 is not in the extension
header map. I added 51 to the test's list of numbers that render as `meta
l4proto` (b1e0fd6526).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
