Copilot commented on code in PR #13281:
URL: https://github.com/apache/cloudstack/pull/13281#discussion_r4216508326
##########
client/pom.xml:
##########
@@ -979,6 +979,10 @@
<exclude>org.bouncycastle:bcprov-jdk18on</exclude>
<exclude>org.bouncycastle:bcpkix-jdk18on</exclude>
<exclude>org.bouncycastle:bctls-jdk18on</exclude>
+
<exclude>org.bouncycastle:bcprov-jdk15on</exclude>
+
<exclude>org.bouncycastle:bcpkix-jdk15on</exclude>
+
<exclude>org.bouncycastle:bctls-jdk15on</exclude>
+
<exclude>org.bouncycastle:bcutil-jdk15on</exclude>
Review Comment:
These exclusions change the management-server runtime classpath, but the PR
is scoped and described only as changing agent SELinux/AppArmor setup. Please
remove this unrelated packaging change from this PR or split it into a
separately explained and verified change so its Bouncy Castle compatibility
impact can be reviewed independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
