Damans227 commented on code in PR #14367:
URL: https://github.com/apache/cloudstack/pull/14367#discussion_r4222010564
##########
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/keycloak/KeycloakOAuth2Provider.java:
##########
@@ -54,13 +58,17 @@ public class KeycloakOAuth2Provider extends AdapterBase
implements UserOAuth2Aut
public static final String KEYCLOAK_PROVIDER = "keycloak";
- protected String idToken = null;
-
@Inject
OauthProviderDao oauthProviderDao;
private CloseableHttpClient httpClient;
+ private final Cache<String, String> validatedEmailCache =
+ Caffeine.newBuilder()
+ .expireAfterWrite(60, TimeUnit.SECONDS)
+ .maximumSize(1024)
+ .build();
+
Review Comment:
yes, both calls need to land on the same server. thats the same as the
google login today, and the old code kept the token on one server too, so this
doesnt make it worse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
