Damans227 commented on code in PR #14368:
URL: https://github.com/apache/cloudstack/pull/14368#discussion_r4223217215
##########
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##########
@@ -418,10 +418,6 @@ private ConsoleEndpoint generateAccessEndpoint(Long vmId,
String sessionUuid, St
}
String rootUrl = managementServer.getConsoleAccessUrlRoot(vmId);
Review Comment:
should we skip the console proxy lookup for direct consoles? right now it
still ties the vm to a proxy it never uses when one exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
