Copilot commented on code in PR #14307:
URL: https://github.com/apache/cloudstack/pull/14307#discussion_r4223275813
##########
debian/control:
##########
@@ -24,7 +24,7 @@ Description: CloudStack server library
Package: cloudstack-agent
Architecture: all
-Depends: ${python:Depends}, ${python3:Depends}, openjdk-17-jre-headless |
java17-runtime-headless | java17-runtime | zulu-17, cloudstack-common (=
${source:Version}), lsb-base (>= 9), openssh-client, qemu-kvm (>= 2.5) |
qemu-system-x86 (>= 5.2), libvirt-bin (>= 1.3) | libvirt-daemon-system (>=
3.0), iproute2, ebtables, vlan, ipset, python3-libvirt, ethtool, iptables,
cryptsetup, rng-tools, rsync, ovmf, swtpm, lsb-release, ufw, apparmor,
cpu-checker, libvirt-daemon-driver-storage-rbd, sysstat, python3-libnbd, socat
+Depends: ${python:Depends}, ${python3:Depends}, openjdk-17-jre-headless |
java17-runtime-headless | java17-runtime | zulu-17, cloudstack-common (=
${source:Version}), lsb-base (>= 9), openssh-client, qemu-kvm (>= 2.5) |
qemu-system-x86 (>= 5.2), libvirt-bin (>= 1.3) | libvirt-daemon-system (>=
3.0), iproute2, ebtables, vlan, ipset, python3-libvirt, ethtool, iptables,
cryptsetup, rng-tools, rsync, ovmf, swtpm, lsb-release, ufw, apparmor,
cpu-checker, libvirt-daemon-driver-storage-rbd, sysstat, python3-libnbd, socat,
openssl, bzip2, gzip, unzip
Review Comment:
The agent's direct-download path first executes `file` to detect compression
and also supports `.xz` by invoking `xz`
(`TemplateDownloaderUtil.java:35-38,55-56`). Neither executable is declared
here, so a minimal agent installation can still fail before using these newly
added decompressors or fail specifically for xz templates. Please add Debian's
`file` and `xz-utils` runtime packages as well.
##########
packaging/suse15/cloud.spec:
##########
@@ -127,6 +127,10 @@ Requires: rng-tools
Requires: (libgcrypt > 1.8.3 or libgcrypt20)
Requires: (selinux-tools if selinux-tools)
Requires: sysstat
+Requires: openssl
+Requires: bzip2
+Requires: gzip
+Requires: unzip
Review Comment:
The agent's direct-download path first executes `file` to detect compression
and also supports `.xz` by invoking `xz`
(`TemplateDownloaderUtil.java:35-38,55-56`). Neither executable is declared
here, so a minimal agent installation can still fail before using these newly
added decompressors or fail specifically for xz templates. Please add the
`file` and `xz` runtime packages as well.
##########
packaging/el8/cloud.spec:
##########
@@ -129,6 +129,10 @@ Requires: (selinux-tools if selinux-tools)
Requires: sysstat
Requires: python3-libnbd
Requires: socat
+Requires: openssl
+Requires: bzip2
+Requires: gzip
+Requires: unzip
Review Comment:
The agent's direct-download path first executes `file` to detect compression
and also supports `.xz` by invoking `xz`
(`TemplateDownloaderUtil.java:35-38,55-56`). Neither executable is declared
here, so a minimal agent installation can still fail before using these newly
added decompressors or fail specifically for xz templates. Please add the
`file` and `xz` runtime packages as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
