MitchDrage commented on code in PR #14373:
URL: https://github.com/apache/cloudstack/pull/14373#discussion_r4236314093
##########
engine/components-api/src/main/java/com/cloud/network/vpc/VpcManager.java:
##########
@@ -57,6 +57,13 @@ public interface VpcManager {
true,
ConfigKey.Scope.Global,
null);
+ ConfigKey<Integer> VpcMaxNetworks = new ConfigKey<>("Advanced",
+ Integer.class,
+ "vpc.max.networks",
+ "3",
+ "Maximum number of networks per VPC. Can be overridden per domain
and per account",
+ true,
+ List.of(ConfigKey.Scope.Account, ConfigKey.Scope.Domain));
Review Comment:
Thanks Damans. You were right - a domain admin could change the setting for
their domain.
Since I've pivoted the idea here, it's no longer applicable as it's back to
being a global setting. See the other comment in the PR and the new description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
