jmsperu commented on code in PR #12847:
URL: https://github.com/apache/cloudstack/pull/12847#discussion_r4251909891
##########
core/src/main/java/org/apache/cloudstack/backup/DeleteBackupCommand.java:
##########
@@ -71,6 +71,6 @@ public void setMountOptions(String mountOptions) {
@Override
public boolean executeInSequence() {
- return true;
+ return false;
Review Comment:
Good catch @abh1sar, you are right. The slots live in each management
server's memory, so with more than one management server a host could get up to
N times the configured limit. I will make it cluster safe in this PR: take a DB
backed GlobalLock per host and count the backups already in flight on that host
from the database instead of the in-memory map, so the limit holds across all
management servers. I will push the change and ping when it is ready for
another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
