jmsperu commented on PR #12898: URL: https://github.com/apache/cloudstack/pull/12898#issuecomment-6132371420
Rebased on the current 4.22 (1d2eec1dd4). The branch history had several merges of 4.22, so it is now one commit on top of 4.22; the message lists the commits it replaces. The only upstream change that conflicted was "Nasbackup quiesce fixes" (#14305): - TakeBackupCommand and NASBackupProvider: kept both sides, the enhancement details and validation from this PR plus the new quiesce timeout setting and the cleanup failure alert. - nasbackup.sh: kept both option sets (compression, bandwidth, encryption, verify and --quiesce-timeout) in the variables, usage text and argument parsing, and took upstream's `exit 1` after a failed backup job. - LibvirtTakeBackupCommandWrapperTest was added on both sides: upstream's file stays as is and this PR's enhancement flag tests now live in LibvirtTakeBackupCommandWrapperEnhancementFlagsTest. core, NAS plugin and KVM plugin build with checkstyle; NASBackupProviderTest 31/31, Libvirt take/restore backup wrapper tests 32/32; bash -n clean. Ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
