Damans227 commented on code in PR #14224:
URL: https://github.com/apache/cloudstack/pull/14224#discussion_r4258767006
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java:
##########
@@ -273,14 +257,14 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
final int setDowntime =
dm.migrateSetMaxDowntime(migrateDowntime);
if (setDowntime == 0 ) {
isMigrateDowntimeSet = true;
- logger.debug("Set max downtime for migration of "
+ vmName + " to " + String.valueOf(migrateDowntime) + "ms");
+ logger.debug("Set max downtime for migration of {}
to {}ms", vmName, String.valueOf(migrateDowntime));
}
} catch (final LibvirtException e) {
- logger.debug("Failed to set max downtime for
migration, perhaps migration completed? Error: " + e.getMessage());
+ logger.warn("Failed to set max downtime for migration.
It might happen if the migration has already completed. Error: {}",
e.getMessage());
Review Comment:
can we keep this at debug? it retries every 100ms until it works, so as a
warn it can flood the agent log during a long migration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
