Damans227 commented on code in PR #14073:
URL: https://github.com/apache/cloudstack/pull/14073#discussion_r4262154010


##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -5037,14 +5047,69 @@ protected String 
getMinimumHypervisorVersionInDatacenter(long datacenterId, Hype
         return StringUtils.isBlank(minHwVersion) ? defaultHypervisorVersion : 
minHwVersion;
     }
 
+    /**
+     * The number of CD-ROM devices of the Instance. Each CD-ROM device 
occupies a device id, starting from
+     * {@link TemplateManager#CDROM_PRIMARY_DEVICE_SEQ}.
+     */
+    protected int getVmCdromCount(VirtualMachine vm) {
+        return 1;

Review Comment:
   on main a second cd drive sits on 4 too, so should the config drive move 
past the last cd slot when this merges forward?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to