weizhouapache commented on code in PR #14194:
URL: https://github.com/apache/cloudstack/pull/14194#discussion_r4259750965
##########
plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java:
##########
@@ -255,8 +264,30 @@ static ChainDecision incremental(String bitmapNew, String
bitmapParent, List<Str
parentPaths, chainId, chainPosition);
}
+ /**
+ * Full backup on the content-based (pull mode) path: no bitmap, no
checkpoint, but it
+ * does anchor a chain so later content-incrementals can hang off it.
+ */
+ static ChainDecision contentFull() {
+ return new ChainDecision(NASBackupChainKeys.TYPE_CONTENT_FULL,
null, null, null,
Review Comment:
nice @rp-
I will see if I can use method in my PR for RBD volumes #14386, for example
method=rbd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
