Damans227 commented on code in PR #13022:
URL: https://github.com/apache/cloudstack/pull/13022#discussion_r4270743275
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/acl/project/ListProjectRolesCmd.java:
##########
@@ -72,7 +72,10 @@ public String getRoleName() {
@Override
public void execute() {
- List<ProjectRole> projectRoles = new ArrayList<>();
+ if (getProjectId() != null &&
_projectService.getProject(getProjectId()) == null) {
Review Comment:
should listProjectRolePermissions get the same check? with a removed project
it looks like it crashes the same way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
