Damans227 commented on code in PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#discussion_r4272817056


##########
ui/src/views/offering/AddNetworkOffering.vue:
##########
@@ -1062,6 +1073,9 @@ export default {
           if (values.specifyvlan === true) {
             params.specifyvlan = true
           }
+
+          params.specifyipranges = values.specifyipranges

Review Comment:
   what happens if someone turns this on and then ticks source nat again? the 
switch hides but the value is still sent, so the create fails



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to