andrijapanicsb commented on PR #14256:
URL: https://github.com/apache/cloudstack/pull/14256#issuecomment-6176060548
Merging this one. Against the project's merge rules it now has everything:
- **Two LGTMs:**
- @rp-, the LINSTOR plugin maintainer,
[approved](https://github.com/apache/cloudstack/pull/14256#pullrequestreview-5438388762)
it after the three LINSTOR import issues he raised were fixed (01058cd674,
ce349d813e).
- @alexandremattioli wrote ["Tested,
LGTM"](https://github.com/apache/cloudstack/pull/14256#issuecomment-6150053871).
- **Independent testing:** @alexandremattioli tested warm CBT migration to
QCOW2 and Ceph, and @rp- reviewed and approved the LINSTOR side as its
maintainer.
- **Clean smoke tests on the current head (95fc5b5):** Trillian tid-17130
reports 157 OK, 0 errors, 0 not run
([result](https://github.com/apache/cloudstack/pull/14256#issuecomment-6171906675)).
Thanks @NuxRo for kicking it off.
- **Mergeable:** no conflicts with main. The only failing check is the Sonar
JaCoCo coverage gate.
Compared with #13656, this PR also carries the fixes found in review:
- the CBT checkpoint between delta cycles (a5578d6f53; thanks
@rajiv-jain-netapp);
- cutover failure handling (6fa7d30b47);
- imported-VM disk protection (fd1673629d);
- the importVm dummy-template fix ported from #14195 (2a3598ad6a);
- the LINSTOR import validation and pagination fixes (01058cd674,
ce349d813e).
Thanks everyone for the reviews and testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
