Damans227 commented on code in PR #13363:
URL: https://github.com/apache/cloudstack/pull/13363#discussion_r4284674490
##########
server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java:
##########
@@ -992,20 +972,15 @@ public boolean
postStateTransitionEvent(StateMachine2.Transition<State, Event> t
releaseVmCapacity(vm, false, false, oldHost);
}
} else if (oldState == State.Stopped) {
- if (event == Event.DestroyRequested || event ==
Event.ExpungeOperation) {
+ if (event == Event.DestroyRequested || event == Event.ExpungeOperation
|| event == Event.StartRequested) {
Review Comment:
what happens if the start fails after this? the held spot on the old host is
now freed before a new host is even picked, so the vm loses it for good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
