Damans227 commented on code in PR #13415:
URL: https://github.com/apache/cloudstack/pull/13415#discussion_r4283837256
##########
ui/src/utils/guiTheme.js:
##########
@@ -63,6 +63,10 @@ async function applyDynamicCustomization (response) {
jsonConfig = JSON.parse(response?.jsonconfiguration)
}
+ if (response?.customlabelspath) {
+ updateMessages(response.customlabelspath)
Review Comment:
should we wait for the custom labels before the app mounts? the fetch isnt
awaited so the first screen can still show the default labels
##########
ui/src/locales/index.js:
##########
@@ -47,6 +48,17 @@ function fetchLocale (lang) {
.then(json => applyMessages(lang, json))
}
+export function updateMessages (customPath) {
+ fetch(`${customPath}/${systemLang}.json`)
Review Comment:
what happens when a user switches language? looks like the custom labels are
only loaded for the language picked at startup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
