Damans227 commented on code in PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#discussion_r4295787156
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -983,6 +985,8 @@ private Answer execute(ResizeVolumeCommand cmd) {
VirtualDisk disk = getDiskAfterResizeDiskValidations(vmMo, path);
String vmdkAbsFile = VmwareHelper.getAbsoluteVmdkFile(disk);
+ setDiskIops(disk, newReadRateIops, newWriteRateIops);
Review Comment:
what happens when someone only grows the disk and keeps the same offering?
looks like the iops limit gets reset to unlimited here
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -5179,6 +5199,8 @@ private Answer execute(MigrateVolumeCommand cmd) {
volumePath = vmMo.getVmdkFileBaseName(disk);
}
}
+
+ setDiskIops(cmd, vmMo, volumePath);
Review Comment:
what happens when a volume is migrated without a new offering? looks like it
loses its iops limit here
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1519,7 +1524,7 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws
ResourceAllocationExcep
}
return orchestrateResizeVolume(volume.getId(), currentSize,
newSize, newMinIops, newMaxIops, newHypervisorSnapshotReserve, newDiskOffering
!= null ? cmd.getNewDiskOfferingId() : null,
- shrinkOk);
+ shrinkOk, newWriteRateIops, newReadRateIops);
Review Comment:
read and write look swapped here compared to the other two calls. is that on
purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
