weizhouapache commented on PR #14320: URL: https://github.com/apache/cloudstack/pull/14320#issuecomment-6218832693
> Thanks @weizhouapache, I went through the GUID change manually and then used Claude Fable to check it again. > > The naming is consistent on both sides: the checker uses `HostTO.getGuid()`, the agent composes `guid + "-" + name` where `name` is what `Agent.getResourceName()` passes to `configure()`, so both give `<uuid>-LibvirtComputingResource`, as your manual test log shows. The NFS and SharedMountPoint paths still use the private IP, so rolling upgrades are safe. LibvirtStoragePoolTest (19), LibvirtComputingResourceTest (323) and the activity wrapper test (5) pass here. > > Looks good now. Remove the draft status and it is good to merge. great, thanks for the reviews and suggestions, very useful ! @wido @kiranchavala could you please test it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
