wido opened a new pull request, #14422: URL: https://github.com/apache/cloudstack/pull/14422
### Description The KVM agent copies the `video.hardware` and `guest.cpu.model` VM details into the domain XML as-is. Every other detail that ends up in the XML (disk controller, NIC model, TPM) is mapped through an enum first, these two were the exception. `VideoDef` now has a `VideoModel` enum with the model types libvirt accepts (vga, cirrus, vmvga, xen, vbox, qxl, virtio, gop, bochs, ramfb, none), matched case-insensitively. `CpuModeDef` only accepts plain QEMU model names such as `Nehalem`, `EPYC-Rome-v2` or `x86-64-v2`. An unknown value is logged and ignored, the agent property or the x86 default is used instead. libvirt rejects unknown model types anyway, so existing working setups are unaffected. ### Types of changes - [x] Enhancement (improves an existing feature and functionality) ### Feature/Enhancement Scale or Bug Severity - [x] Minor ### How Has This Been Tested? Unit tests added to `LibvirtVMDefTest` and `LibvirtComputingResourceTest`, covering case-insensitive matching, an unknown agent property, an unknown detail and the fallback to the agent default. Both classes pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
