Damans227 commented on code in PR #14413:
URL: https://github.com/apache/cloudstack/pull/14413#discussion_r4297146733
##########
ui/src/views/compute/wizard/ComputeSelection.vue:
##########
@@ -226,10 +274,28 @@ export default {
}
if (this.preFillContent.memory) {
this.memoryInputValue = this.preFillContent.memory
+ this.memoryDisplayValue = parseFloat((this.memoryInputValue /
1024).toFixed(2))
}
this.updateComputeCpuNumber(this.preFillContent.cpunumber ||
this.cpuNumberInputValue)
this.updateComputeCpuSpeed(this.preFillContent.cpuspeed ||
this.cpuSpeedInputValue)
- this.updateComputeMemory(this.preFillContent.memory ||
this.memoryInputValue)
+ this.updateComputeMemory(this.memoryDisplayValue)
Review Comment:
np. maybe, we can open it in MiB when the value isnt a whole number of GiB?
then 1500 stays 1500. on load and on a unit switch, send the saved MiB value as
is and only convert when the user changes the number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
