DaanHoogland commented on code in PR #14357:
URL: https://github.com/apache/cloudstack/pull/14357#discussion_r4313879759
##########
api/src/main/java/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLItemCmd.java:
##########
@@ -99,11 +101,15 @@ public Long getId() {
}
public String getProtocol() {
- if (protocol != null) {
- return protocol.trim();
- } else {
+ if (protocol == null) {
return null;
}
+ String p = protocol.trim();
+ // As on create, protocol number 1 is ICMP so that it keeps its icmp
type and code
Review Comment:
```suggestion
```
I think this is what the code says allready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
