JoaoJandre commented on code in PR #13901:
URL: https://github.com/apache/cloudstack/pull/13901#discussion_r4317436004
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtTakeKbossBackupCommandWrapper.java:
##########
@@ -297,8 +298,13 @@ protected void convertDeltaToSecondary(String
pathDeltaOnPrimary, String pathDel
createDirsIfNeeded(pathDeltaOnSecondary, volumeUuid);
QemuImg qemuImg = new QemuImg(waitInMillis);
- qemuImg.convert(backupOrigin, backupDestination, parentBackup, null,
null, new QemuImageOptions(backupOrigin.getFormat(),
backupOrigin.getFileName(), null), null,
- true, false, false, false, null, null);
+ Map<String, String> options = new HashMap<>();
+ if (command.isCompress()) {
+ qemuImg.setCompressionTypeOptionIfAvailable(options,
command.getCompressionLib());
+ }
+ qemuImg.convert(backupOrigin, backupDestination, parentBackup,
options, null, new QemuImageOptions(backupOrigin.getFormat(),
backupOrigin.getFileName(), null), null,
+ true, false, false, command.isCompress(),
command.getCoroutines(), command.getRateLimit());
Review Comment:
After closer inspection, yes it would break things. I have fixed it now. I
also fixed the out of order writes to use the same value as in the compression
process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
