slavkap commented on code in PR #14389:
URL: https://github.com/apache/cloudstack/pull/14389#discussion_r4323455611
##########
server/src/main/java/org/apache/cloudstack/storage/volume/VolumeImportUnmanageManagerImpl.java:
##########
@@ -232,9 +241,11 @@ public VolumeResponse importVolume(ImportVolumeCmd cmd) {
}
}
- protected VolumeOnStorageTO getVolumeOnStorageAndCheck(StoragePoolVO pool,
String volumePath) {
+ protected VolumeOnStorageTO getVolumeOnStorageAndCheck(StoragePoolVO pool,
String volumePath, boolean forUnmanage) {
// send a command to hypervisor to check
- List<VolumeOnStorageTO> volumes = listVolumesForImportInternal(pool,
volumePath, null);
+ List<VolumeOnStorageTO> volumes = forUnmanage
+ ? listVolumesForImportInternal(pool, volumePath, null, true)
+ : listVolumesForImportInternal(pool, volumePath, null);
Review Comment:
thanks, @nvazquez! Made the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
