rootnomad commented on code in PR #14038:
URL: https://github.com/apache/cloudstack/pull/14038#discussion_r4326092469
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -1120,10 +1120,12 @@ private NicVO checkForRaceAndAllocateNic(final
NicProfile requested, final Netwo
}
if (vo == null) {
- if (requested.getRequestedIPv4() != null) {
- throw new
InsufficientVirtualNetworkCapacityException("Unable to acquire requested Guest
IP address " + requested.getRequestedIPv4() + " for network " + network,
DataCenter.class, dcVo.getId());
- } else {
- requested.setIPv4Address(null);
+ if (requested != null) {
Review Comment:
Good point, thanks. Updated the description to drop the bulk/autoscale/cks
examples, since those are user VMs that build a profile. It now says the
null-requested path is the internal deploys that pass no profile: basic-zone
reallocate and the control and management NICs on routers and system VMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
