bhouse-nexthop commented on PR #14189: URL: https://github.com/apache/cloudstack/pull/14189#issuecomment-6366473076
@DaanHoogland thanks. It's a fair thing to check, but this doesn't add a new dependency. `LibvirtStorageAdaptor` already runs `mountpoint -q` in two places on 4.22. `checkNetfsStoragePoolMounted()` and the stale-mount check in `createNetfsStoragePool()` both came in with #8887 in 4.20, and this change reuses the same call. `mountpoint` is part of util-linux, which is a base package on every distro the KVM agent supports (EL8/9/10, Ubuntu/Debian, SUSE). It's the same package that provides `umount` itself. One thing to note: if the binary were ever missing, the shell would return 127 and the new check would read the pool as unmounted. That failure would be easy to spot, though. With `mountpoint` missing, `checkNetfsStoragePoolMounted()` would already fail every NFS pool create on that host, so the agent couldn't use NFS primary storage at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
