DaanHoogland commented on code in PR #14460:
URL: https://github.com/apache/cloudstack/pull/14460#discussion_r4375256201
##########
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java:
##########
@@ -5432,6 +5432,7 @@ private void
handlePowerOnReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
ActionEventUtils.onActionEvent(User.UID_SYSTEM,
Account.ACCOUNT_ID_SYSTEM, vm.getDomainId(),
EventTypes.EVENT_VM_START, "Out of band VM power on",
vm.getId(), getApiCommandResourceTypeForVm(vm).toString());
logger.info("VM {} is sync-ed to at Running state according to
power-on report from hypervisor.", vm.getInstanceName());
+ reconcileNicsForRunningVm(vm);
Review Comment:
why do we need it in the stopped||stopping block? if the VM never reports as
running again we have a spare nic in our nic count. should it be added to the
start block instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
