EduFrazao commented on code in PR #13603:
URL: https://github.com/apache/cloudstack/pull/13603#discussion_r4388967746
##########
core/src/main/java/com/cloud/resource/ServerResourceBase.java:
##########
@@ -75,6 +80,12 @@ public boolean configure(final String name, Map<String,
Object> params) throws C
defineResourceNetworkInterfaces(params);
+ if (privateNic == null) {
+ checkForPrivateInterfaceDefinedByIp(params);
Review Comment:
Hi @Damans227
In my tests, private.network.device is never collected by
params.get("private.network.device") even if its present on agent.properties.
On the hypervisor side, this setting works, because system vms are correctly
placed on this device (that is a bridge linked to a VNI).
But as it is never resolved as private nic on the ServerResourceBase in this
step, the original behavior is to jump into
tryToAutoDiscoverResourcePrivateNetworkInterface() that picks the first local
ip address regardless of the owner interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
