RosiKyu commented on PR #14407:
URL: https://github.com/apache/cloudstack/pull/14407#issuecomment-6464896774
Tested on build 4.22.2.0-shapeblue22281 (head 7afd3e96951), upgraded from
4.22.1.0. The q35 hosts use config drive and NAS backup. The baseline was also
checked on 4.22.1.1.
**LGTM for the reported issue:** on q35 config drive VMs, the 3rd data
volume no longer takes deviceid 4, on running and stopped VMs. No regression
was found.
### Tested/Verified
- The bug reproduces on 4.22.1.0, on both running and stopped VMs.
- PR build, q35 scsi and virtio config drive VMs: data volumes get 1, 2, 5,
and the VMs start.
- VMs without config drive: no change, deviceid 4 is still used.
- Explicit device ids: 3 and 4 are rejected with the new message. Out of
range ids are rejected, and free ids are accepted.
- Limits and lifecycle:
- the 32-volume limit is still reachable;
- after a detach, the lowest free id is reused;
- stop/start, reboot and live migration keep the device ids;
- with an ISO attached, the next volume skips 3 and 4;
- after a config drive NIC is added, the next volume gets 5.
- Upgrade:
- a new management server with old agents already gives 5;
- existing i440fx VMs with a volume on 4 keep working.
- Behaviour change: an explicit deviceid=4 on i440fx config drive VMs is now
rejected.
- NAS backup: create a VM from a backup and restore in place both keep the
ids, and the VM starts.
- Unmanaged import into a config drive network: data volumes get 1, 2, 5,
and the VM starts.
### Potential issues identified
1. A VM created from a backup reuses the backup's deviceid 4 on a config
drive network. Take a backup of a VM without config drive that has its 3rd data
volume on deviceid 4. Then create a VM from that backup on a config drive
network. The volume keeps deviceid 4, and the VM can't start (target 'sde'
duplicated). It reproduced 4 of 4 times. It also fails on 4.22.1.1, so the PR
didn't cause it. The same backup on a network without config drive gives a
running VM. Creating the VM with explicit device ids 1, 2, 5 also gives a
running VM.
2. Known limitation from the Notes, confirmed: a config drive VM that
already has a data volume on deviceid 4 still can't start. This covers VMs
upgraded from 4.22.1.0 and VMs that get a config drive NIC later. After a
detach and attach, the volume gets deviceid 5 and the VM starts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
