andrijapanicsb commented on code in PR #14223:
URL: https://github.com/apache/cloudstack/pull/14223#discussion_r4400708403
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java:
##########
@@ -361,7 +361,7 @@ private void
validateKubernetesClusterScaleSizeParameters(KubernetesClusterNodeT
}
}
- private void scaleKubernetesClusterOffering(KubernetesClusterNodeType
nodeType, ServiceOffering serviceOffering,
+ protected void scaleKubernetesClusterOffering(KubernetesClusterNodeType
nodeType, ServiceOffering serviceOffering,
Review Comment:
Thanks Daan. Those were the 9 SonarCloud findings, they're fixed in
c48bd344ee, and Sonar should clear them once it finishes analysing that commit.
The other annotations on the build checks ("TestHook interrupted while
sleeping") are log lines from DisconnectHooksTest in the KVM plugin, which this
PR doesn't touch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
